soundcloud: fix extraction of client_id#1497
Merged
wukko merged 1 commit intoimputnet:developfrom Jan 9, 2026
Merged
Conversation
* hydratable regex courtesy of https://git.canine.tools/canine.tools/cobalt/commit/6d77edd0a0fb5ac6b4083b40e66cf675281e2fed, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SoundCloud seems to have broken on main & develop because the regex for matching the client_id didn't match anything on newer versions anymore. This PR fixes the regex & tries to extract the client_id from hydration data first (before eventually falling back to getting it from the JS files)
The regex for matching the client_id from the hydration data is courtesy of https://git.canine.tools/canine.tools/cobalt/commit/6d77edd0a0fb5ac6b4083b40e66cf675281e2fed, thanks to @hyperdefined for it