fix: re-evaluate OIDC role claim on every login and support array values#29991
Open
ImperatorRuscal wants to merge 1 commit into
Open
fix: re-evaluate OIDC role claim on every login and support array values#29991ImperatorRuscal wants to merge 1 commit into
ImperatorRuscal wants to merge 1 commit into
Conversation
…rray values Previously the OIDC role claim (immich_role) was only read at user auto-registration time and only accepted as a scalar string, so admin status never updated after the first login and array-valued role/group claims (common with Keycloak, Entra ID, etc.) were silently ignored. Now the role claim is normalized from either a string or an array of strings, and existing users have their isAdmin flag synced from the claim on every login, keeping the IdP as the source of truth for privileges while leaving isAdmin untouched when the claim is blank.
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🗄️server. A maintainer will add the required label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously the OIDC role claim (recommended:
immich_role) was only read at user auto-registration time and only accepted as a scalar string, so admin status never updated after the first login and array-valued role/group claims (common with Azure AD/Entra ID, along with may other IdPs) were silently ignored.Now the role claim is normalized from either a string or an array of strings, and existing users have their isAdmin flag synced from the claim on every login, keeping the IdP as the source of truth for privileges while leaving isAdmin untouched when the claim is blank.
How Has This Been Tested?
"roles": ["admin","user"]) detects admin (This used a standard Entra ID application role assignment w/o claims mappings for the testing)isAdminupdated based on the presence of theadminRoleClaimuserin the event RoleClaim doesn't containadmin, regardless of the presence of theuservalue (it defaults safe to user, even on malformed or null claim results)Screenshots (if appropriate)
No visible/UI changes, all server processing of OIDC auth
API Changes
No API changes in the PR
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)src/repositories/Please describe to which degree, if any, an LLM was used in creating this pull request.
Coding performed by a human. An internal Code Review was performed with Claude Sonnet 5.