Allow multiplying by a unit#510
Open
portyanikhin wants to merge 3 commits intoiliekturtles:masterfrom
Open
Conversation
portyanikhin
force-pushed
the
add-mul-impls-for-units
branch
from
5376f0f to
74d4143
Compare
portyanikhin
force-pushed
the
add-mul-impls-for-units
branch
from
74d4143 to
12069e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially closes #366 and #367. I think it will greatly improve the usability, e.g.:
I've tried many solutions to this issue. In my opinion, this is the only option that doesn't require breaking changes (and the only option that worked). On the downside, I noticed that the compilation time has increased.
Anyway, a review is needed here.
It's possible that there will be a better solution.