Add an artifact that loads in firefox. Add a missing logo. Update the… - #14
Open
timcleaver wants to merge 1 commit into
Open
Add an artifact that loads in firefox. Add a missing logo. Update the…#14timcleaver wants to merge 1 commit into
timcleaver wants to merge 1 commit into
Conversation
… manifest.json to be firefox ready (but probably breaks chrome).
ilhan-mstf
added
hacktoberfest
hacktoerfest:accepted
hacktoberfest-accepted
and removed
hacktoerfest:accepted
labels
Owner
|
Hi, thank you for your contribution. I'll make check it in a couple of days. |
ilhan-mstf
reviewed
Dec 6, 2020
ilhan-mstf
left a comment
ilhan-mstf
left a comment
Owner
There was a problem hiding this comment.
I prefer not to add zip to repo. Can you remove it?
I should create tags for releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the changes required to make this extension usable on Firefox. I am not sure whether that is something you want so I have done the bare minimum. The changes probably break it for Chrome so to get this upstream properly, should you want it, you would need a build script or similar to build a different release for each browser. Feel free to decline if you don't want to support or release for Firefox.