Do not allow to dismiss a monster by mouse right-clicking - #10181
Draft
ihhub wants to merge 1 commit into
Draft
Conversation
This is against the whole concept using mouse right-click for gathering information. DISMISS button in the monster dialog is the correct way of doing things.
ihhub
added
improvement
|
Districh-ru
requested changes
Sep 16, 2025
Districh-ru
left a comment
Districh-ru
left a comment
Collaborator
There was a problem hiding this comment.
Hi @ihhub,
IMHO we should not do this change for now because:
- all other bars (artifacts, secondary skills) use the right-click for remove and it will be not good if one of the bars will have the other logic,
- to dismiss a troop in this PR the mapmaker should do more actions: double click the troop, click DISMISS button, click OK in the confirmation dialog,
- the remove by right-click logic was used in Battle Only for many years and many people have gotten used to using that logic in editing dialogs.
In example, we can add extra overlay sprites (or buttons) for every item in the bar to remove it by left click, something like this:
And apply the same logic to all bars in the dialog.
Any other suggestions to ensure consistent logic across all dialog items are welcome. :)
| } | ||
| } | ||
|
|
||
| if ( can_change && keepLastTroop ) { |
Collaborator
There was a problem hiding this comment.
The Dialog::DISMISS flag should be set if we do not need to keep the last troop in the army:
Suggested change
| if ( can_change && keepLastTroop ) { | |
| if ( can_change && !keepLastTroop ) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is against the whole concept of using mouse right-click for gathering information. DISMISS button in the monster dialog is the correct way of doing things.
This affects Battle Only and the Editor.
close #9991