chore: Add optional parameter to packer.Unpack #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x1m3
commented
Oct 21, 2024
packers/zkp.go
Outdated
|
|
||
| // VerificationHandlerFunc registers the handler function for state verification. | ||
| type VerificationHandlerFunc func(id circuits.CircuitID, pubsignals []string) error | ||
| type VerificationHandlerFunc func(id circuits.CircuitID, pubsignals []string, opts ...DefaultZKPUnpackerOption) error |
Contributor
Author
There was a problem hiding this comment.
Open question. Is it ok to use DefaultZKPUnpackerOption or we should create a new Option type?
Contributor
There was a problem hiding this comment.
My proposal it's add UnpackerParams in the same way how we did with PackerParams and use them instead of DefaultZKPUnpackerOption
Contributor
There was a problem hiding this comment.
I mean the function verificationKey.VerificationFn.Verify(circuits.CircuitID(token.CircuitID), token.ZkProof.PubSignals, verifyOpts...) should accept ZKPPUnpackerParams
packers/zkp.go
Outdated
| } | ||
|
|
||
| func (d *defaultZKPUnpacker) defaultZkpUnpackerVerificationFn(id circuits.CircuitID, pubsignals []string) error { | ||
| func (d *defaultZKPUnpacker) defaultZkpUnpackerVerificationFn(id circuits.CircuitID, pubsignals []string, opts ...DefaultZKPUnpackerOption) error { |
Contributor
There was a problem hiding this comment.
If you will remove opts from defaultZKPUnpacker, you can refactor the method to function.
Contributor
Author
There was a problem hiding this comment.
I don't think so. It is using d.resolvers inside the method body.
…nstead of DefaultZKPUnpackerOption
use zkp unpacker params only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional parameter to packer.Unpack function and change the implementation of the the ZKKPacker unpack code to support parameter with custom AuthVerifyDelay