Skip to content

Activity Leak in PermissionsControllerImpl during Configuration Change Fix #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex009 merged 1 commit into from
Aug 28, 2025
Merged

Activity Leak in PermissionsControllerImpl during Configuration Change Fix #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 24 additions & 36 deletions permissions/src/androidMain/kotlin/dev/icerock/moko/permissions/PermissionsControllerImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@ import androidx.core.content.ContextCompat
import androidx.lifecycle.Lifecycle
import androidx.lifecycle.LifecycleEventObserver
import androidx.lifecycle.LifecycleOwner
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.filterNotNull
import kotlinx.coroutines.flow.first
import kotlinx.coroutines.sync.Mutex
import kotlinx.coroutines.sync.withLock
import kotlinx.coroutines.withTimeoutOrNull
import java.util.UUID
import kotlin.coroutines.suspendCoroutine

@Suppress("TooManyFunctions")
class PermissionsControllerImpl(
Expand All @@ -38,11 +38,12 @@ class PermissionsControllerImpl(

private val launcherHolder = MutableStateFlow<ActivityResultLauncher<Array<String>>?>(null)

private var permissionCallback: PermissionCallback? = null
private val permissionRequestResultFlow = MutableSharedFlow<PermissionRequestResult>(extraBufferCapacity = 1)

private val key = UUID.randomUUID().toString()

override fun bind(activity: ComponentActivity) {
unbindActivity()
this.activityHolder.value = activity
val activityResultRegistryOwner = activity as ActivityResultRegistryOwner

Expand All @@ -52,28 +53,20 @@ class PermissionsControllerImpl(
) { permissions ->
val isCancelled = permissions.isEmpty()

val permissionCallback = permissionCallback ?: return@register

if (isCancelled) {
permissionCallback.callback.invoke(
Result.failure(RequestCanceledException(permissionCallback.permission))
)
permissionRequestResultFlow.tryEmit(PermissionRequestResult.CANCELLED)
return@register
}

val success = permissions.values.all { it }

if (success) {
permissionCallback.callback.invoke(Result.success(Unit))
permissionRequestResultFlow.tryEmit(PermissionRequestResult.GRANTED)
} else {
if (shouldShowRequestPermissionRationale(activity, permissions.keys.first())) {
permissionCallback.callback.invoke(
Result.failure(DeniedException(permissionCallback.permission))
)
permissionRequestResultFlow.tryEmit(PermissionRequestResult.DENIED)
} else {
permissionCallback.callback.invoke(
Result.failure(DeniedAlwaysException(permissionCallback.permission))
)
permissionRequestResultFlow.tryEmit(PermissionRequestResult.DENIED_ALWAYS)
}
}
}
Expand All @@ -83,8 +76,7 @@ class PermissionsControllerImpl(
val observer = object : LifecycleEventObserver {
override fun onStateChanged(source: LifecycleOwner, event: Lifecycle.Event) {
if (event == Lifecycle.Event.ON_DESTROY) {
this@PermissionsControllerImpl.activityHolder.value = null
this@PermissionsControllerImpl.launcherHolder.value = null
unbindActivity()
source.lifecycle.removeObserver(this)
}
}
Expand All @@ -96,26 +88,17 @@ class PermissionsControllerImpl(
mutex.withLock {
val launcher = awaitActivityResultLauncher()
val platformPermission = permission.delegate.getPlatformPermission()
suspendCoroutine { continuation ->
requestPermission(
launcher,
permission,
platformPermission
) { continuation.resumeWith(it) }
launcher.launch(platformPermission.toTypedArray())

when (permissionRequestResultFlow.first()) {
PermissionRequestResult.GRANTED -> Unit
PermissionRequestResult.DENIED -> throw DeniedException(permission)
PermissionRequestResult.DENIED_ALWAYS -> throw DeniedAlwaysException(permission)
PermissionRequestResult.CANCELLED -> throw RequestCanceledException(permission)
}
}
}

private fun requestPermission(
launcher: ActivityResultLauncher<Array<String>>,
permission: Permission,
permissions: List<String>,
callback: (Result<Unit>) -> Unit
) {
permissionCallback = PermissionCallback(permission, callback)
launcher.launch(permissions.toTypedArray())
}

private suspend fun awaitActivityResultLauncher(): ActivityResultLauncher<Array<String>> {
val activityResultLauncher = launcherHolder.value
if (activityResultLauncher != null) return activityResultLauncher
Expand Down Expand Up @@ -194,12 +177,17 @@ class PermissionsControllerImpl(
applicationContext.startActivity(intent)
}

private fun unbindActivity() {
launcherHolder.value?.unregister()
activityHolder.value = null
launcherHolder.value = null
}

private companion object {
private const val AWAIT_ACTIVITY_TIMEOUT_DURATION_MS = 2000L
}
}

private class PermissionCallback(
val permission: Permission,
val callback: (Result<Unit>) -> Unit
)
private enum class PermissionRequestResult {
GRANTED, DENIED, DENIED_ALWAYS, CANCELLED
}
Loading