Skip to content

fix iOS background location permission state and requesting #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex009 merged 2 commits into from
Aug 18, 2025
Merged

fix iOS background location permission state and requesting #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
180dd9f
fix: iOS background location permission state returns granted when on…
ryancfogarty Jun 25, 2025
f9a515c
fix: requesting background location permissions
ryancfogarty Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...ation/src/iosMain/kotlin/dev/icerock/moko/permissions/location/LocationManagerDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,18 @@ internal class LocationManagerDelegate : NSObject(), CLLocationManagerDelegatePr
locationManager.delegate = this
}

fun requestLocationAccess(callback: (CLAuthorizationStatus) -> Unit) {
fun requestWhenInUseAuthorization(callback: (CLAuthorizationStatus) -> Unit) {
this.callback = callback

locationManager.requestWhenInUseAuthorization()
}

fun requestAlwaysAuthorization(callback: (CLAuthorizationStatus) -> Unit) {
this.callback = callback

locationManager.requestAlwaysAuthorization()
}

override fun locationManager(
manager: CLLocationManager,
didChangeAuthorizationStatus: CLAuthorizationStatus
Expand Down
38 changes: 28 additions & 10 deletions ...cation/src/iosMain/kotlin/dev/icerock/moko/permissions/location/LocationPermission.ios.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ package dev.icerock.moko.permissions.location

import dev.icerock.moko.permissions.DeniedAlwaysException
import dev.icerock.moko.permissions.Permission
import dev.icerock.moko.permissions.PermissionState
import dev.icerock.moko.permissions.PermissionDelegate
import dev.icerock.moko.permissions.PermissionState
import platform.CoreLocation.CLAuthorizationStatus
import platform.CoreLocation.CLLocationManager
import platform.CoreLocation.kCLAuthorizationStatusAuthorizedAlways
Expand All @@ -30,8 +30,13 @@ private class LocationPermissionDelegate(
override suspend fun getPermissionState(): PermissionState {
val status: CLAuthorizationStatus = CLLocationManager.authorizationStatus()
return when (status) {
kCLAuthorizationStatusAuthorizedAlways,
kCLAuthorizationStatusAuthorizedWhenInUse -> PermissionState.Granted
kCLAuthorizationStatusAuthorizedAlways -> PermissionState.Granted
kCLAuthorizationStatusAuthorizedWhenInUse -> {
when (permission) {
BackgroundLocationPermission -> PermissionState.NotGranted
else -> PermissionState.Granted
}
}

kCLAuthorizationStatusNotDetermined -> PermissionState.NotDetermined
kCLAuthorizationStatusDenied,
Expand All @@ -44,21 +49,34 @@ private class LocationPermissionDelegate(
status: CLAuthorizationStatus
) {
when (status) {
kCLAuthorizationStatusAuthorizedAlways,
kCLAuthorizationStatusAuthorizedWhenInUse -> return

kCLAuthorizationStatusNotDetermined -> {
val newStatus = suspendCoroutine<CLAuthorizationStatus> { continuation ->
locationManagerDelegate.requestLocationAccess { continuation.resume(it) }
kCLAuthorizationStatusAuthorizedAlways -> Unit
kCLAuthorizationStatusAuthorizedWhenInUse -> {
if (permission == BackgroundLocationPermission) {
requestAlwaysAuthorization()
}
provideLocationPermission(newStatus)
}

kCLAuthorizationStatusNotDetermined -> requestWhenInUseAuthorization()

kCLAuthorizationStatusDenied,
kCLAuthorizationStatusRestricted -> throw DeniedAlwaysException(permission)
else -> error("unknown location authorization status $status")
}
}

private suspend fun requestWhenInUseAuthorization() {
val newStatus = suspendCoroutine { continuation ->
locationManagerDelegate.requestWhenInUseAuthorization { continuation.resume(it) }
}
provideLocationPermission(newStatus)
}

private suspend fun requestAlwaysAuthorization() {
val newStatus = suspendCoroutine { continuation ->
locationManagerDelegate.requestAlwaysAuthorization { continuation.resume(it) }
}
provideLocationPermission(newStatus)
}
}

actual val locationDelegate: PermissionDelegate =
Expand Down