Conversation
Release 0.18.0
Add the missing 'contacts' permission to README.md
| } | ||
|
|
||
| override suspend fun getPermissionState(permission: Permission): PermissionState { | ||
| return PermissionState.Granted |
There was a problem hiding this comment.
it's not true. on macos for example we have runtime permissions and JVM desktop should work with it too
| @@ -0,0 +1,25 @@ | |||
| package dev.icerock.moko.permissions | |||
| @@ -0,0 +1,39 @@ | |||
| package dev.icerock.moko.permissions | |||
| @@ -0,0 +1,13 @@ | |||
| package dev.icerock.moko.permissions.compose | |||
| @@ -0,0 +1,15 @@ | |||
| package dev.icerock.moko.permissions.compose | |||
|
any update on this pull? |
|
Any change to get this done? |
|
After the JVM hot reload release, this library is useless until it has a JVM implementation. |
|
Any updates on this? |
|
Any news on this? |
|
Is no one clicking merge because...? |
|
because mock implementation is not that expected by library users by default. if library will support jvm target by default and just do nothing in runtime it will confuse users. |
|
|
There no crash. When project contains unsupported target Gradle will not find dependency and can't compile project. |
|
You're right. Yet still library force project to has a specific config. |
|
I understand the reasoning, but more often than not, people are going to add the library to the common source set expecting that it will handle iOS, Android and Desktop You say that it has no reason for it to be enabled for JVM, and I agree, but I argue that providing an implementation that always says "Yeah, whatever" on Desktop is more friendly and saves the users the hassle of making actual/expects for simple permissions Middle ground would be an annotation called @AcknowledgeJvmAlwaysTrue or something |
|
Two years to merge a pull request which makes the lives of developers easier... |
Yes, but the problem is that not all desktop OSes just don't have permissions. macOS is similar to iOS in this regard, to use Bluetooth for example you have to go through the permission system to get access to the BLE API, and just saying "whatever permission granted" will not be true, at least on macOS. Idk about Windows and Linux tho |
12 participants
#101