Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
Given that:
When a user presses Super + Space
Then the user sees a space added to the text field and layout not switched
Expected
Given that:
When a user presses Super + Space
Then the user sees that Anthy is no longer the active IBus Engine
Root Cause
The super key modifier is ignored only in thumb shift mode.
In Thumb Shift Mode (
__process_key_event_thumb()):In Romaji or Kana Mode (
__process_key_event_internal2()):Solution
Supplement
MOD4_MASKto the state usages specific to thumb shift mode.Remarks
Please let me know if there are practices that I should follow.