Skip to content

Conversation

@skorya
Copy link

@skorya skorya commented Jan 25, 2026

PR Type

Enhancement


Description

  • Expands VTX SmartAudio frequency range support

  • Increases minimum frequency from 5000 MHz to 1000 MHz

  • Increases maximum frequency from 5999 MHz to 8000 MHz

  • Enables custom video frequency configuration capability


Diagram Walkthrough

flowchart LR
  A["VTX SmartAudio Frequency Limits"] -- "MIN: 5000 → 1000 MHz" --> B["Extended Lower Bound"]
  A -- "MAX: 5999 → 8000 MHz" --> C["Extended Upper Bound"]
  B --> D["Broader Frequency Support"]
  C --> D
Loading

File Walkthrough

Relevant files
Enhancement
vtx_smartaudio.h
Expand SmartAudio frequency range limits                                 

src/main/io/vtx_smartaudio.h

  • Updated VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ from 5000 to 1000 MHz
  • Updated VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ from 5999 to 8000 MHz
  • Expands supported frequency range for custom video frequency
    configuration
+2/-2     

@github-actions
Copy link

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@qodo-code-review
Copy link
Contributor

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

Comment on lines +40 to +41
#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 1000 //min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 8000 //max freq in MHz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Keep VTX_SMARTAUDIO_* frequency limits aligned with the SmartAudio band/spec expectations, and introduce separate *_CUSTOM_* (or config-layer) bounds for the expanded range to avoid inconsistent behavior across modules that assume 5.8GHz-only limits. [Learned best practice, importance: 6]

Suggested change
#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 1000 //min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 8000 //max freq in MHz
#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 5000 // SmartAudio spec min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 5999 // SmartAudio spec max freq in MHz
#define VTX_SMARTAUDIO_CUSTOM_MIN_FREQUENCY_MHZ 1000 // custom/config min freq in MHz
#define VTX_SMARTAUDIO_CUSTOM_MAX_FREQUENCY_MHZ 8000 // custom/config max freq in MHz

@sensei-hacker
Copy link
Member

We're not going to be illegally blasting junk on the strategic missile defense radar frequencies, the landing approach radar, etc etc. This is a non-starter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants