Skip to content

core: move fail_timeout from input-field to general#718

Merged
vaxerski merged 1 commit intohyprwm:mainfrom
PointerDilemma:main
Apr 2, 2025
Merged

core: move fail_timeout from input-field to general#718
vaxerski merged 1 commit intohyprwm:mainfrom
PointerDilemma:main

Conversation

@PointerDilemma
Copy link
Collaborator

@PointerDilemma PointerDilemma commented Mar 25, 2025

Initial version of this PR intended to fix some edge cases when rapidly providing input, where you would see the fail color, but no fail text placeholder.

Now it does that plus moving the input-field:fail_timeout setting.
It is easier and more flexible to handle the duration for which an auth failure gets displayed outside of the PasswordInputField widget.
Now per input-field fail_timeout settings wont be supported, but that didn't work anyways (smallest fail_timeout always took precedence)

@PointerDilemma PointerDilemma changed the title input-field: callback when placeholder text rendered and immediatly reset fail if passwordLength > 0 core: move fail_timeout from input-field to general Mar 26, 2025
@PointerDilemma
Copy link
Collaborator Author

PointerDilemma commented Mar 26, 2025

So input-field:fail_timeout -> auth:fail_timeout.
Or should it be general:fail_timeout??

Edit: picked general:fail_timeout, since its a setting related to authentication directly.

@vaxerski
Copy link
Member

up to you

@PointerDilemma
Copy link
Collaborator Author

I feel a bit bad about the breaking change, but I think it's just necessary.
It sucks having that within the input-field.

@vaxerski for merge cause related wiki mr

@PointerDilemma PointerDilemma requested a review from vaxerski April 2, 2025 07:25
@vaxerski vaxerski merged commit ce1eb7b into hyprwm:main Apr 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants