core: move fail_timeout from input-field to general#718
Merged
vaxerski merged 1 commit intohyprwm:mainfrom Apr 2, 2025
Merged
Conversation
Collaborator
Author
|
So Edit: picked |
Member
|
up to you |
23f789c to
885b126
Compare
Collaborator
Author
|
I feel a bit bad about the breaking change, but I think it's just necessary. @vaxerski for merge cause related wiki mr |
vaxerski
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial version of this PR intended to fix some edge cases when rapidly providing input, where you would see the fail color, but no fail text placeholder.
Now it does that plus moving the
input-field:fail_timeoutsetting.It is easier and more flexible to handle the duration for which an auth failure gets displayed outside of the PasswordInputField widget.
Now per input-field fail_timeout settings wont be supported, but that didn't work anyways (smallest
fail_timeoutalways took precedence)