Skip to content

core: more hyprutils smart pointer usage and safe references to widgets#686

Merged
PointerDilemma merged 6 commits intohyprwm:mainfrom
PointerDilemma:main
Mar 5, 2025
Merged

core: more hyprutils smart pointer usage and safe references to widgets#686
PointerDilemma merged 6 commits intohyprwm:mainfrom
PointerDilemma:main

Conversation

@PointerDilemma
Copy link
Collaborator

@PointerDilemma PointerDilemma commented Feb 12, 2025

Closes #684

@PointerDilemma
Copy link
Collaborator Author

I couldn't hold myself and renamed a bunch of stuff making this way to big.
Will undo the renaming and then move it out of draft.

Maybe we should get that before 0.7.0.

Stuff I am not that happy with yet:

  • registerSelf can't be virtual, but we need m_self to safely create a ref to the current widget.
  • using lambdas for the callbacks kind of makes the static handler methods in the widgets redundant. Perhaps removing them and just calling the widgets methods in the lambda directly is better.

@PointerDilemma PointerDilemma changed the title DRAFT: core: more hyprutils smart pointer usage and safe reference to widgets core: more hyprutils smart pointer usage and safe reference to widgets Mar 1, 2025
@PointerDilemma PointerDilemma changed the title core: more hyprutils smart pointer usage and safe reference to widgets core: more hyprutils smart pointer usage and safe references to widgets Mar 1, 2025
@PointerDilemma PointerDilemma marked this pull request as ready for review March 1, 2025 14:49
@PointerDilemma
Copy link
Collaborator Author

@vaxerski I think this is ready

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at your discretion

@PointerDilemma PointerDilemma merged commit 9f37c1c into hyprwm:main Mar 5, 2025
1 check passed
PointerDilemma added a commit to PointerDilemma/hyprlock that referenced this pull request Mar 6, 2025
Fixes a regression caused by hyprwm#686 (Images don't render cause of a missing resourceId)
PointerDilemma added a commit to PointerDilemma/hyprlock that referenced this pull request Mar 6, 2025
Fixes a regression caused by hyprwm#686 (Images don't render cause of a missing resourceId)
PointerDilemma added a commit that referenced this pull request Mar 6, 2025
Fixes a regression caused by #686 (Images don't render cause of a missing resourceId)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unplugging/Removing an output may result in dangling pointers

2 participants