support other_custom_types stellar example - #1996
Merged
Islam-Imad merged 1 commit intoAug 12, 2026
Merged
Conversation
Islam-Imad
force-pushed
the
soroban/examples/other_custom_types
branch
2 times, most recently
from
August 11, 2026 09:21
3cfe41d to
8ef6065
Compare
Islam-Imad
marked this pull request as ready for review
August 11, 2026 09:29
Islam-Imad
requested review from
salaheldinsoliman and
seanyoung
as code owners
August 11, 2026 09:29
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Stellar Soroban other_custom_types example by porting the Solidity contract into the repository, documenting it in the Soroban examples coverage guide, adding a comprehensive Rust testcase suite, and fixing Soroban ABI enum encoding to match the spec.
Changes:
- Add
other_custom_typesSolidity example (bothexamples/anddocs/examples/) and document it in the Soroban examples coverage guide. - Add a new Soroban testcase module with end-to-end ABI round-trip tests for primitives, enums, structs, vectors, events/auth, and error handling.
- Fix Soroban argument encoding for Solidity enums to use
U32Val(unsigned) instead ofI32Val, aligning with the ABI type (ScSpecTypeDef::U32) and the existing decode path.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/soroban_testcases/mod.rs | Registers the new example_other_custom_types testcase module. |
| tests/soroban_testcases/example_other_custom_types.rs | Adds end-to-end Soroban tests covering ABI round-trips, events/auth, and reverts for the example. |
| src/codegen/targets/soroban/encoding.rs | Fixes enum argument encoding to use unsigned U32Val tags per ABI. |
| examples/soroban/other_custom_types.sol | Adds the Solidity port of the upstream Soroban example for users/examples. |
| docs/examples/soroban/other_custom_types.sol | Adds the same Solidity port for documentation embedding/linking. |
| docs/targets/soroban_examples_coverage.rst | Documents the new example’s coverage and removes it from the “not yet documented” list. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Islam-Imad <islamimad404@gmail.com>
Islam-Imad
force-pushed
the
soroban/examples/other_custom_types
branch
from
August 11, 2026 12:06
8ef6065 to
2162006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1960