Skip to content

core: fix judger login if builtin login disabled #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
undefined-moe merged 2 commits into from
May 7, 2026
+6 −3
Merged

core: fix judger login if builtin login disabled #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0717006
core: fix judger login if builtin login disabled
renbaoshuo May 7, 2026
7e05969
rename
undefined-moe May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/hydrojudge/src/hosts/hydro.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,8 @@ export default class Hydro implements Session {
async login() {
log.info('[%s] Updating session', this.config.host);
const res = await this.post('login', {
uname: this.config.uname, password: this.config.password, rememberme: 'on',
uname: this.config.uname, password: this.config.password,
rememberme: 'on', judge: 'on',
});
const setCookie = res.headers['set-cookie'];
await this.setCookie(Array.isArray(setCookie) ? setCookie.join(';') : setCookie);
Expand Down
6 changes: 4 additions & 2 deletions packages/hydrooj/src/handler/user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,15 @@ class UserLoginHandler extends Handler {
@param('redirect', Types.String, true)
@param('tfa', Types.String, true)
@param('authnChallenge', Types.String, true)
@param('judge', Types.Boolean, true)
async post(
domainId: string, uname: string, password: string, rememberme = false, redirect = '',
tfa = '', authnChallenge = '',
tfa = '', authnChallenge = '', judge = false,
) {
if (!system.get('server.login')) throw new BuiltinLoginError();
if (!judge && !system.get('server.login')) throw new BuiltinLoginError();
let udoc = await user.getByEmail(domainId, uname);
udoc ||= await user.getByUname(domainId, uname);
if (judge && !system.get('server.login') && !udoc?.hasPriv(PRIV.PRIV_JUDGE)) throw new BuiltinLoginError();
if (!udoc) throw new UserNotFoundError(uname);
if (system.get('system.contestmode') && !udoc.hasPriv(PRIV.PRIV_EDIT_SYSTEM)) {
if (udoc._loginip && udoc._loginip !== this.request.ip) throw new ValidationError('ip');
Expand Down
Loading