PG16-PG17: call RelationGetSmgr instead of custom code#278
Open
ivan-v-kush wants to merge 2 commits intohydradatabase:mainfrom
Open
PG16-PG17: call RelationGetSmgr instead of custom code#278ivan-v-kush wants to merge 2 commits intohydradatabase:mainfrom
ivan-v-kush wants to merge 2 commits intohydradatabase:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a preparation PR for PG16 to migrate hydra to PG17. Can be merged in PG16 version
This code should be changed in PG17, will be added one more
#elif.Will be changedto
smgrpinSee MR in PostgresBut this logic is included in the standard function
RelationGetSmgr. Also see the same code in the Citus repositoryhttps://github.com/citusdata/citus/blob/f7bead22d478ac3f407b1fb0f23739a289743bcc/src/backend/columnar/columnar_tableam.c#L1891