Conversation
) Previously, EntityFindBase.oneInternal() would strip all non-PK conditions when a full primary key was provided, treating them as "over-constrained". This was semantically incorrect as users may legitimately want to validate additional conditions alongside PK lookups (e.g., status checks). Changes: - Removed the code block that discarded non-PK conditions (lines 783-796) - Added test to verify non-PK conditions are honored with PK queries Before: ec.entity.find("Entity").condition("pk", "1").condition("status", "ACTIVE") would ignore the status condition entirely. After: Both pk AND status conditions are included in the query. Fixes #14 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where
EntityFindBase.oneInternal()would strip all non-PK conditions when a full primary key was provided, treating them as "over-constrained".Root Cause
Lines 783-796 in
EntityFindBase.groovycontained logic that:Example of the Bug
The Fix
Test Plan
"find with PK and non-PK conditions should honor all conditions"./gradlew test)Upstream Reference
Fixes #14
🤖 Generated with Claude Code