fix: add support for aarch64 Linux architecture#129
Open
alexfaber2011 wants to merge 1 commit intohuggingface:mainfrom
Open
fix: add support for aarch64 Linux architecture#129alexfaber2011 wants to merge 1 commit intohuggingface:mainfrom
alexfaber2011 wants to merge 1 commit intohuggingface:mainfrom
Conversation
Add aarch64 to architecture mapping to support Linux systems that report architecture as aarch64 (e.g., ARM-based Linux environments). macOS reports as arm64, but Linux reports as aarch64 directly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
duplicate of #111 I just realized, but I'll let ya'll decide what to do with it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for aarch64 Linux systems by including
aarch64in the architecture mapping.Problem
The plugin currently fails to start on aarch64 Linux systems with the error:
This occurs because Linux systems report their architecture as
aarch64, while macOS ARM systems report asarm64. The architecture mapping only includedarm64, causing Linux aarch64 detection to fail.Solution
Added
aarch64 = "aarch64"to thearch_mapinlua/llm/language_server.lua. This allows both:arm64)aarch64)to correctly map to the same binary:
llm-ls-aarch64-{os-suffix}Testing
Tested on aarch64 Linux environment where the error previously occurred. The plugin now correctly:
llm-ls-aarch64-unknown-linux-gnu)🤖 Generated with Claude Code