Skip to content

Add new pattern for zipped AnnData Zarr store#161

Merged
jswelling merged 2 commits intomasterfrom
jswelling/recognize-zipped-zarrs
Jan 22, 2026
Merged

Add new pattern for zipped AnnData Zarr store#161
jswelling merged 2 commits intomasterfrom
jswelling/recognize-zipped-zarrs

Conversation

@jswelling
Copy link
Contributor

Some Zarr archives are not zipped to save space and filenames. The old manifest regex did not recognize such files as valid data products. This version adds a term to recognize them.

Some Zarr archives are not zipped to save space and filenames.  The old manifest regex did not recognize such files as valid data products.  This version adds a term to recognize them.
NickAkhmetov
NickAkhmetov previously approved these changes Jan 20, 2026
Copy link
Contributor

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Good catch!

@jswelling
Copy link
Contributor Author

jswelling commented Jan 20, 2026

@NickAkhmetov it looks like I guessed the EDAM code wrong. By analogy to anndata-to-ui it should be EDAM_1.24.format_3987 .

Copy link
Contributor

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jswelling I've patched the term

@jswelling
Copy link
Contributor Author

jswelling commented Jan 21, 2026

Thank you @NickAkhmetov . What is your protocol for who merges the PR? Should I do so? I'm not sure I have permissions, though it's showing me the Merge button.

@jswelling jswelling merged commit dcabe21 into master Jan 22, 2026
2 checks passed
@jswelling jswelling deleted the jswelling/recognize-zipped-zarrs branch January 22, 2026 19:17
@jswelling
Copy link
Contributor Author

Yup, looks like I can merge PRs. I hope that's OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants