Conversation
|
A couple of advice, I think you should work with the dev branch. Because there are a lot of changes coming up with this release, it will later ease your rebase. Although I don't know when @bpetit plan to release it. |
Thanks for the early feedback, I will rebase my branch against dev, and set dev as target branch for this PR. I will also look for clap 4 stuff early since you will probably merge your PR before mine. 👍 |
08091c4 to
5eb31ea
Compare
|
I will watch for main > dev sync in order to remove the non-related commits. |
895360f to
1fb85fb
Compare
ec80dfe to
e2278ef
Compare
e2278ef to
8953cec
Compare
b7de5c6 to
f6a2da2
Compare
|
👋 everyone, hope you are doing well. I finally have time to work on this PR 🤞 ! Here is some basic stuff, with all the internal Scaphandre metrics. I'll probably rename it a bit. Here is, IMO, the next steps :
After that it should be ready for review ! |
Context
This PR adds Elastic search as a new exporter for Scaphandre. Linked to #92.