Use gen_all_metrics() for Riemann exporter#194
Open
uggla wants to merge 2 commits intohubblo-org:mainfrom
Open
Use gen_all_metrics() for Riemann exporter#194uggla wants to merge 2 commits intohubblo-org:mainfrom
uggla wants to merge 2 commits intohubblo-org:mainfrom
Conversation
Collaborator
uggla
commented
Jul 17, 2022
uggla
commented
- Riemann is now using the helper functions to retrieve metrics like the prometheus exporter. This makes the code a bit shorter but mainly prevent discrepencies beetween exporter metrics.
- Fix clippy warning coming from rust 1.62.
- Refactor to use MetricGenerator.
- Fix clippy warning from rust 1.62.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.