Remove vehicle type from agent interface - #1294
Conversation
| if mission.vehicle_spec == None: | ||
| vehicle_type = "sedan" | ||
| else: | ||
| vehicle_type = mission.vehicle_spec.veh_config_type |
There was a problem hiding this comment.
is this the right place to get the vehicle type?
There was a problem hiding this comment.
Yes, although I am slightly confused as to why the vehicle_spec is inside the mission rather than in the plan.
There was a problem hiding this comment.
where should vehicle_spec be specified then?
| name=self._agent_manager.agent_name(agent_id), | ||
| actor_type=actor_type, | ||
| vehicle_type=envision_types.VehicleType.Car, | ||
| vehicle_type=veh_type, |
There was a problem hiding this comment.
This change seems to cause the ego vehicle to be the wrong color (grey instead of red) on SUMO maps
| """Vehicle specifications""" | ||
|
|
||
| veh_id: str | ||
| veh_config_type: str |
There was a problem hiding this comment.
This is problematic because we have been and are still distinguishing in our (core) code between veh_type and veh_config_type, where the latter should eventually be fully encapsulated to just the Sumo types (per Issue #1270). I do not think we should be exposing the "config" (Sumo) types in Scenario Studio, but to just change the variable name here to veh_type would also be a misnomer without further unification in the core. Thus, I suggest we deal with this as part of the more comprehensive solution that issue #1270 requires.
3 participants
#753