panel: reuse single rich str instead two alloc rich str#1892
Open
GermanAizek wants to merge 1 commit intohtop-dev:mainfrom
Open
panel: reuse single rich str instead two alloc rich str#1892GermanAizek wants to merge 1 commit intohtop-dev:mainfrom
GermanAizek wants to merge 1 commit intohtop-dev:mainfrom
Conversation
Explorer09
reviewed
Feb 9, 2026
Panel.c
Outdated
| } | ||
|
|
||
| static void RichString_reset(RichString* this) { | ||
| this->chlen = 0; |
Contributor
There was a problem hiding this comment.
This would cause memory leak. this->chptr is not freed when you set the length of RichString to 0.
EDIT: You should use RichString_setLen for what you are doing.
Contributor
Author
There was a problem hiding this comment.
Many thanks. Good catch.
Contributor
Author
There was a problem hiding this comment.
@Explorer09, fix it here 1dad083
Review again please.
Contributor
Author
There was a problem hiding this comment.
@Explorer09, I can't use function RichString_setLen because it's static.
I use hack RichString_rewind(&item, RichString_size(&item)); that equivalent RichString_setLen(rs, 0)
GermanAizek
force-pushed
the
reuse-richstr-panel
branch
from
0978460 to
1dad083
Compare
Reallocation rich string inside body for loop may be impractical with freeing inside, same applies to new and old rich strings, it would be more logical to use one object and reuse it to save memory
Explorer09
reviewed
Feb 9, 2026
| : CRT_colors[PANEL_SELECTION_UNFOCUS]; | ||
|
|
||
| if (this->needsRedraw || force_redraw) { | ||
| RichString_begin(item); |
Contributor
There was a problem hiding this comment.
If you are gonna reuse the buffer, why not use it throughout the whole function? Don't initialize the string inside an if-block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reallocation rich string inside body for loop may be impractical with freeing inside, same applies to new and old rich strings, it would be more logical to use one object and reuse it to save memory