Merged
Conversation
Explorer09
commented
Feb 1, 2025
Explorer09
force-pushed
the
init-degree-sign
branch
from
a0d8100 to
441b4fd
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
from
441b4fd to
45e0e5d
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
4 times, most recently
from
66e8617 to
6a092bb
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
2 times, most recently
from
ba2b686 to
3d6fe6c
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
from
3d6fe6c to
663f7b1
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
2 times, most recently
from
1008050 to
5bd5f41
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
2 times, most recently
from
a0cefc3 to
131c25f
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
4 times, most recently
from
a33354d to
ca0c7c8
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
2 times, most recently
from
a8f69d0 to
6800ae8
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
3 times, most recently
from
1aaf558 to
a8f9d3d
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
from
a8f9d3d to
4166451
Compare
Explorer09
force-pushed
the
init-degree-sign
branch
2 times, most recently
from
5ead612 to
923fd18
Compare
BenBE
reviewed
Oct 15, 2025
Explorer09
force-pushed
the
init-degree-sign
branch
from
923fd18 to
b873ce2
Compare
Make "CRT_degreeSign" a writable buffer that will be updated after the initDegreeSign() function. This avoids needing a static buffer in the function. The appropriate buffer size for "CRT_degreeSign" is (MB_LEN_MAX * 2), not 4. One side effect of this change is that "CRT_degreeSign" will lose the const qualifier in the header (CRT.h). Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
Explorer09
force-pushed
the
init-degree-sign
branch
from
b873ce2 to
a52b43b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
CRT_degreeSigna writable buffer that will be updated after theinitDegreeSign()function. This avoids needing a static buffer in the function.Also use
MB_LEN_MAXfor the buffer size, which is more appropriate than the magic number 4.One side effect of this change is that
CRT_degreeSignwill lose the const qualifier in the header (CRT.h).