Fix possible NULL deref when looking for PCP dynamic columns#1591
Merged
BenBE merged 1 commit intohtop-dev:mainfrom Jan 22, 2025
Merged
Fix possible NULL deref when looking for PCP dynamic columns#1591BenBE merged 1 commit intohtop-dev:mainfrom
BenBE merged 1 commit intohtop-dev:mainfrom
Conversation
BenBE
added
bug 🐛
natoscott
approved these changes
Jan 22, 2025
Member
natoscott
left a comment
natoscott
left a comment
There was a problem hiding this comment.
@BenBE LGTM. I thought we were using no-braces for single-line conditionals in general these days, but I'm not particularly fussed if you really want to change that in all these places. The new null-checking code updates there certainly all seem fine anyway. Thanks!
Member
Author
|
@natoscott The brace-less variant is okay too, but within nested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a NULL deref found while working on #1587 …
This also does some code style cleanup of the caller.