Fix unsanitized $_GET params and missing null checks in REST API#1314
Open
jbrejcha wants to merge 14 commits intohtmlburger:developmentfrom
Open
Fix unsanitized $_GET params and missing null checks in REST API#1314jbrejcha wants to merge 14 commits intohtmlburger:developmentfrom
jbrejcha wants to merge 14 commits intohtmlburger:developmentfrom
Conversation
- sanitize_text_field() on container_id and field_id in
get_association_data() and get_association_options()
- Guard against null return from Helper::get_field() before
calling methods on the result (prevents fatal error on unknown field)
- array_pad() on explode(':') result to prevent undefined index
when option string has fewer than 3 parts
- in_array() strict mode (true) in Router and Decorator
Fixes potential fatal errors and input validation issues in the
Association field REST API endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
get_association_data()andget_association_options(),container_idandfield_idare read from$_GETwithout sanitization and without anisset()check. The return value ofHelper::get_field()is also used without a null check — passing an unknown field ID causes a fatal error.Changes
sanitize_text_field()+isset()oncontainer_idandfield_idin both methodsHelper::get_field()before calling methods on the resultarray_pad()onexplode(':', $option)to prevent undefined index when option string has fewer than 3 partsin_array()strict mode inRouterandDecorator