allow max_retries=0 #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
added
bug
Collaborator
|
tested and it works as intended |
jhiemstrawisc
approved these changes
Jan 21, 2026
Collaborator
jhiemstrawisc
left a comment
jhiemstrawisc
left a comment
There was a problem hiding this comment.
This looks okay to me. I'll note that @guechhouth is working on a follow-up PR to use a helper function that should handle all the other parameters that fall into this trap (she identified a handful).
Collaborator
|
@cefect, before this is merged, can you rebase it against the current main branch? |
cefect
force-pushed
the
max_retries_patch
branch
from
23fe16f to
c152ff4
Compare
Collaborator
|
The current CI failure is a known issue I haven't had time to sort out yet. This looks good to me after the rebase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not tested