Open
Conversation
- add support for ionic css4 color classes
|
Hey @mixuala - any ideas how I can get your package into my project via npm? Thanks |
Author
|
It's been a long time since I last built an NPM package. It's possible and
if you know how, it's easy. But easier is just to add the component
directly to your project.
…On Thu, Mar 21, 2019 at 4:30 AM Gez Quinn ***@***.***> wrote:
Hey @mixuala <https://github.com/mixuala> - any ideas how I can get your
package into my project via npm? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Aed57Sz0WFx20DAmQRBunngcO40nzaMrks5vYpp9gaJpZM4a80j6>
.
|
|
So, how do I get the component? I've ran the build script on your repo but it fails because it's looking for the Angular 4 references - should I update the package.json in your repo before building the package? Apologies for the noobiness. |
Author
|
all my changes were in the then just import the something like this: |
|
Up, it's possible to merge this please ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how to update your npm package, but these changes worked for my ionic 4 project