Open
Conversation
- Add projects-teams API endpoint tests - Fix project teams exceptions and retrieval of user id
d-rita
force-pushed
the
chore/add-project-teams-tests
branch
from
d950790 to
db00081
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Aadesh-Baral
reviewed
Apr 5, 2023
| response_body["Error"], "User is not an admin or a manager for the team" | ||
| ) | ||
| self.assertEqual(response_body["SubCode"], "UserPermissionError") | ||
|
|
Contributor
There was a problem hiding this comment.
A test to determine if 403 is raised when the user does not have permission to update the project appears to be missing as well. Only a team's user permission is tested in the test above
Also test to determine whether a 400 is raised when an invalid team role is passed appears to be missing.
| self.assertEqual(response.status_code, 403) | ||
| self.assertEqual(response_body["Error"], "User is not a manager of the project") | ||
| self.assertEqual(response_body["SubCode"], "UserPermissionError") | ||
|
|
Contributor
There was a problem hiding this comment.
Same here a test to determine whether a 400 is raised when an invalid team role is passed appears to be missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles project-teams related API endpoint tests.
How to test:
test_git fetch origin && git checkout chore/add-project-teams-testspython3 -m unittest discover tests/backend