feat: support boxed singular read model relationships - #231
Open
patrickleet wants to merge 2 commits into
Open
Conversation
Implements [[tasks/distributed-boxed-readmodel-relations]]
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Implements [[tasks/distributed-dev-startup-watch]]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Read models can have valid cyclic one-to-one relationships, but Rust cannot store
both sides inline. Authors need
Option<Box<T>>to represent that shape withoutchanging a singular GraphQL relationship into a collection or introducing JSON.
What changes
ReadModelnow accepts a single box inside an optionalbelongs_tofield:The box affects only Rust storage. Schema metadata, GraphQL cardinality, typed
effect/projection relationship markers, and included rows still target the model
inside it. Hydration allocates the box; serialization reads through it.
Wrong targets, unsupported wrappers, and multiple rows for a singular include
still fail. This does not add a blanket read-model implementation for
Box,change SQL storage, or alter authorization.
Validation
rows, included schema, and serialization.
permission denial.
fixtures passed. CI is running as an additional gate.
CI-discovered startup race
The initial CI run timed out in an existing lifecycle test. Investigation found
that
distributed devcaptured its first watch baseline after child startup,so a source edit during startup could be silently accepted as an unbuilt baseline.
A new held-readiness test fails on the prior code and passes after capturing the
baseline before the initial build/startup. The existing 11 lifecycle tests are
unchanged and pass alongside the new regression (12 total). The original CI
timeout did not identify which fixture wait failed, so this is a proven startup
bug rather than a claim to have conclusively explained that CI occurrence.
Stacked on #230, whose base is
v5.Documentation-only copy; no application UI or new user-facing runtime copy.