Update badges and add project growth diagram#22
Conversation
Summary of ChangesHello @hooyuser, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the visual presentation of the project's README. It updates existing badges to use a more integrated and consistent source, and introduces a new graphical element to showcase the project's development progress through a lines-of-code growth diagram. These changes aim to provide clearer and more dynamic insights into the project's status and evolution. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the badges in the README and adds a new project growth diagram. The changes are good, but I've suggested an improvement to the HTML used for the new diagram to align with modern web standards, addressing the use of the obsolete align attribute and the non-standard width attribute on the image.
| <div align="center"> | ||
| <h3>Project Growth</h3> | ||
| <img src="https://raw.githubusercontent.com/hooyuser/github-badges/main/diagrams/hooyuser-Solution-to-Algebra-Chapter-0.svg" width="600px" /> | ||
| <p><i>Tracking Lines of Code over time</i></p> | ||
| </div> |
There was a problem hiding this comment.
The HTML for the project growth section can be improved to better align with modern web standards:
- The
alignattribute on<div>elements is obsolete in HTML5. It's better to use CSS for styling, for example:style="text-align: center;". - The
widthattribute for an<img>tag should be a unitless value representing pixels. Including 'px' is not standard HTML. It should bewidth="600".
Here is a suggested update incorporating these changes.
| <div align="center"> | |
| <h3>Project Growth</h3> | |
| <img src="https://raw.githubusercontent.com/hooyuser/github-badges/main/diagrams/hooyuser-Solution-to-Algebra-Chapter-0.svg" width="600px" /> | |
| <p><i>Tracking Lines of Code over time</i></p> | |
| </div> | |
| <div style="text-align: center;"> | |
| <h3>Project Growth</h3> | |
| <img src="https://raw.githubusercontent.com/hooyuser/github-badges/main/diagrams/hooyuser-Solution-to-Algebra-Chapter-0.svg" width="600" /> | |
| <p><i>Tracking Lines of Code over time</i></p> | |
| </div> |
No description provided.