Skip to content

add constants for SecuritySystemAlarmType#1086

Merged
bwp91 merged 1 commit intolatestfrom
bp/alarm-types
Mar 22, 2025
Merged

add constants for SecuritySystemAlarmType#1086
bwp91 merged 1 commit intolatestfrom
bp/alarm-types

Conversation

@bwp91
Copy link
Contributor

@bwp91 bwp91 commented Mar 22, 2025 •
edited
Loading

I'm assuming that 0 and 1 correspond to these:

public static readonly NO_ALARM = 0;
public static readonly UNKNOWN = 1;

@bwp91 bwp91 requested a review from ebaauw March 22, 2025 12:42
ebaauw
ebaauw approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@ebaauw ebaauw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they do. Thanks!

I'm afraid I fail to understand how the dashes and dots in the generator configuration translate to the camelcase characteristic name and uppercase value constants, but good to see how it's done.

@bwp91 bwp91 merged commit 4d37fb1 into latest Mar 22, 2025
14 checks passed
@bwp91 bwp91 deleted the bp/alarm-types branch March 22, 2025 14:49
bwp91 added a commit that referenced this pull request Jun 1, 2025
@bwp91
add constants for SecuritySystemAlarmType (#1086)
a5eb3d6
bwp91 added a commit that referenced this pull request Jun 4, 2025
@bwp91
add constants for SecuritySystemAlarmType (#1086)
e1e71a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebaauw ebaauw ebaauw approved these changes

Assignees

No one assigned

Labels

latest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bwp91 @ebaauw