Revert #5013 (tabFocusesLinks breaks Mac Catalyst build)#5035
Merged
Conversation
…talyst (#5013)" This reverts commit 265594c. #5013 set WKPreferences.tabFocusesLinks inside a #if targetEnvironment(macCatalyst) block, but that property is macOS/AppKit-only: WebKit's WKPreferences.h gates it with #if !TARGET_OS_IPHONE, and Mac Catalyst has TARGET_OS_IPHONE == 1, so the symbol is absent from the Catalyst SDK. The guard therefore wrapped the call in the one environment where it does not compile, breaking the Mac Catalyst archive in the Distribute workflow: error: value of type 'WKPreferences' has no member 'tabFocusesLinks' ** ARCHIVE FAILED ** PR CI only builds the iOS simulator and never compiles Catalyst, so this slipped through and broke main. Reverting to unblock the Mac distribution build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the Mac Catalyst Tab-focus change introduced in #5013 by removing usage of WKPreferences.tabFocusesLinks, which is unavailable in the Mac Catalyst SDK and caused the Distribute (archive) workflow to fail.
Changes:
- Remove
configuration.preferences.tabFocusesLinks = truefrom the onboarding login web view configuration. - Remove
config.preferences.tabFocusesLinks = truefrom the main frontend web view configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/App/Onboarding/API/OnboardingAuthLoginViewController.swift | Removes the Catalyst-only tabFocusesLinks preference that fails to compile when archiving for Mac Catalyst. |
| Sources/App/Frontend/WebView/WebViewController.swift | Removes the same tabFocusesLinks preference from the primary web view configuration to restore Catalyst archive compatibility. |
Contributor
|
Found 3 unused localization strings in the codebase. Click to see detailsTo remove them, run the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #5013 (
Fix Tab key not moving between web view form fields on Mac Catalyst), which broke the Mac Catalyst archive in the Distribute workflow (failing run):Root cause
#5013 set
WKPreferences.tabFocusesLinks = trueinside a#if targetEnvironment(macCatalyst)block. But that property is macOS/AppKit-only — WebKit'sWKPreferences.hdeclares it under#if !TARGET_OS_IPHONE:Mac Catalyst is an iOS-derived environment (
TARGET_OS_IPHONE == 1), so the symbol is stripped from the Catalyst SDK. The#if targetEnvironment(macCatalyst)guard wrapped the call in exactly the one environment where it can't compile.Why it wasn't caught earlier
The PR pipeline (
ci.yml) only builds the iOS simulator and runs tests; it never compiles Mac Catalyst. The Catalyst archive is compiled only by the Distribute workflow on push tomain, somain's mac build has been broken since #5013 merged (2026-07-09).Reverting to unblock Mac distribution. The original Tab-focus improvement can be revisited with an approach that actually compiles on Catalyst (e.g. a KVC/dynamic set), validated against a real Mac build.
🤖 Generated with Claude Code