Skip to content

Remove advanced setting dependency for IMAP integration#169827

Open
jbouwh wants to merge 2 commits intodevfrom
imap-remove-advanced-settings-dep
Open

Remove advanced setting dependency for IMAP integration#169827
jbouwh wants to merge 2 commits intodevfrom
imap-remove-advanced-settings-dep

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented May 5, 2026

Proposed change

Remove advanced setting dependency for IMAP integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the IMAP integration’s dependency on the (now-removed) “advanced mode” flag by making previously gated configuration and options fields always available in the config/option flows.

Changes:

  • Inlines previously “advanced” fields into the main config and options schemas and removes show_advanced_options branching in the flow.
  • Updates config flow tests to stop passing show_advanced_options in flow/option contexts and to include the SSL-related defaults in MOCK_CONFIG.
  • Updates diagnostics expectations to include the SSL-related config fields.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/imap/config_flow.py Removes advanced-mode gating and makes SSL/template/push-related fields part of the standard schemas.
tests/components/imap/test_config_flow.py Adjusts tests for the new always-visible schema fields and removes advanced-mode context usage in relevant cases.
tests/components/imap/test_diagnostics.py Updates expected diagnostics config payload to include SSL-related fields now present in config entry data.

Comment thread tests/components/imap/test_config_flow.py
Comment thread tests/components/imap/test_config_flow.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

imap - Remove Advanced mode dependency

2 participants