Remove advanced setting dependency for IMAP integration#169827
Open
Remove advanced setting dependency for IMAP integration#169827
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the IMAP integration’s dependency on the (now-removed) “advanced mode” flag by making previously gated configuration and options fields always available in the config/option flows.
Changes:
- Inlines previously “advanced” fields into the main config and options schemas and removes
show_advanced_optionsbranching in the flow. - Updates config flow tests to stop passing
show_advanced_optionsin flow/option contexts and to include the SSL-related defaults inMOCK_CONFIG. - Updates diagnostics expectations to include the SSL-related config fields.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| homeassistant/components/imap/config_flow.py | Removes advanced-mode gating and makes SSL/template/push-related fields part of the standard schemas. |
| tests/components/imap/test_config_flow.py | Adjusts tests for the new always-visible schema fields and removes advanced-mode context usage in relevant cases. |
| tests/components/imap/test_diagnostics.py | Updates expected diagnostics config payload to include SSL-related fields now present in config entry data. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Remove advanced setting dependency for IMAP integration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: