growatt_server: use human-readable labels in exception messages by johanzander · Pull Request #166024 · home-assistant/core

johanzander · 2026-03-19T20:34:40Z

Proposed change

Follow-up to #165314, fixing wording issues in strings.json for the Growatt Server integration.

"service" → "action" wording: The device_not_configured exception message incorrectly said "services" — Home Assistant renamed these to "actions".
Snake_case identifiers in user-visible strings: Exception messages exposed internal Python parameter names (e.g. charge_power must be between 0 and 100). Replaced with proper English labels wrapped in single quotes ('Charge power', 'Charge stop SOC', 'Discharge power', 'Discharge stop SOC', 'Segment ID', 'Start time', 'End time', 'Period N start', 'Period N end').
Action descriptions use third-person singular: All action descriptions now use Reads…, Writes…, Updates… to match HA standards.
Neutral device_id field description for all SPH actions: All four SPH actions now reference the neutral description from read_time_segments instead of action-specific wording.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR is related to issue: Add SPH inverter support to Growatt Server integration #165314

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

@NoRi2909

HA renamed "services" to "actions" in the UI. Update the remaining exception message in strings.json that still used the old term. Fixes review comment by @NoRi2909 on home-assistant#165927. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates the Growatt Server integration’s exception translation string to use Home Assistant’s current “actions” terminology instead of the deprecated “services” wording.

Changes:

Updates the device_not_configured exception message in strings.json from “services” to “actions”.

…able labels in exception messages Use proper English in translated exception messages instead of internal Python parameter names. Charge power, discharge power, SOC limits and time-format errors now show user-friendly labels (e.g. "Charge power", "Period 1 start") rather than snake_case identifiers. Update tests to match the new field_name values. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

homeassistant/components/growatt_server/strings.json

…ld wording - Use third-person singular for all action descriptions (Reads/Writes/Updates) - Fix write_ac_charge_times and write_ac_discharge_times device_id field description from "to read from" to "to write to" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Improves readability and provides a hint to translators that these are field names, not generic text. Dynamic placeholders are left unquoted as ICU message format does not allow placeholders inside single quotes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

homeassistant/components/growatt_server/strings.json

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

homeassistant/components/growatt_server/strings.json

…rge_times The name field "Device" is shared with read actions so it can be referenced rather than duplicated as a literal string. Both write actions point directly to read_ac_charge_times for the name to avoid chained references (Lokalise only supports one level of indirection). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

All four SPH actions (read/write AC charge/discharge times) now reference the neutral "The Growatt device to perform the action on." from read_time_segments instead of action-specific "to read from"/"to write to" wording. All references point directly to read_time_segments to avoid chained references (Lokalise only supports one level of indirection). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

homeassistant/components/growatt_server/services.py

home-assistant · 2026-03-19T21:41:36Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

…t errors Replaces the single invalid_time_format key (which embedded a hardcoded English field name as a placeholder) with four separate translatable keys: invalid_time_format_start_time, invalid_time_format_end_time, invalid_time_format_period_start, invalid_time_format_period_end. This ensures non-English translations do not have English words embedded in otherwise-translated error messages. Period keys use a {period} numeric placeholder which requires no translation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot · 2026-03-19T22:28:06Z

homeassistant/components/growatt_server/services.py

        return datetime.strptime(f"{parts[0]}:{parts[1]}", "%H:%M").time()
    except (ValueError, IndexError) as err:


_parse_time_str claims to accept HH:MM:SS, and the new validation errors/messages also allow that format, but the implementation discards the seconds component by parsing only parts[0]:parts[1]. This will silently turn e.g. 11:00:30 into 11:00. Consider either parsing the full string when 3 components are provided (and validating seconds), or tightening the accepted/advertised format to HH:MM only.

Suggested change

return datetime.strptime(f"{parts[0]}:{parts[1]}", "%H:%M").time()

except (ValueError, IndexError) as err:

if len(parts) == 2:

# Format HH:MM

return datetime.strptime(time_str, "%H:%M").time()

# Format HH:MM:SS

return datetime.strptime(time_str, "%H:%M:%S").time()

except ValueError as err:

Copilot · 2026-03-19T22:28:06Z

homeassistant/components/growatt_server/services.py

            end = _parse_time_str(
                call.data.get(f"period_{i}_end", cached["end_time"]),
-                f"period_{i}_end",
+                "invalid_time_format_period_end",
+                {"period": str(i)},
            )


New translation key path for invalid period end time (invalid_time_format_period_end with {period} placeholder) is introduced here, but the existing tests only assert the start error path. Adding a test that supplies an invalid period_1_end (and ideally one for write_ac_discharge_times too) would prevent future regressions in the raised translation key/placeholders.

homeassistant/components/growatt_server/strings.json

Co-authored-by: Norbert Rittel <norbert@rittel.de>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot · 2026-03-20T07:32:40Z

homeassistant/components/growatt_server/strings.json

+    "invalid_time_format_period_end": {
+      "message": "'Period {period} end' must be in HH:MM or HH:MM:SS format."
+    },
+    "invalid_time_format_period_start": {
+      "message": "'Period {period} start' must be in HH:MM or HH:MM:SS format."


strings.json is currently invalid JSON in this hunk: the invalid_time_format_period_start entry is missing its closing } (and comma), and another key starts immediately after it. This will break translation loading/build; please fix the structure so each exception key is a valid, properly closed JSON object.

Suggested change

"invalid_time_format_period_end": {

"message": "'Period {period} end' must be in HH:MM or HH:MM:SS format."

},

"invalid_time_format_period_start": {

"message": "'Period {period} start' must be in HH:MM or HH:MM:SS format."

},

Github somehow messed this up when I just added the two single quotes on each line.

Copilot · 2026-03-20T07:32:41Z

homeassistant/components/growatt_server/strings.json

+    "invalid_time_format_period_end": {
+      "message": "'Period {period} end' must be in HH:MM or HH:MM:SS format."
+    },
+    "invalid_time_format_period_start": {
+      "message": "'Period {period} start' must be in HH:MM or HH:MM:SS format."


There are duplicate exception keys (invalid_time_format_period_start / invalid_time_format_period_end) defined twice here. Also, one of the duplicates wraps the {period} placeholder inside single quotes ('Period {period} …'), which ICU message formatting treats as escaped text (the placeholder may not be substituted). Keep only one definition per key and ensure placeholders are not inside quoted segments.

Suggested change

"invalid_time_format_period_end": {

"message": "'Period {period} end' must be in HH:MM or HH:MM:SS format."

},

"invalid_time_format_period_start": {

"message": "'Period {period} start' must be in HH:MM or HH:MM:SS format."

},

Using two single quotes in those four places should fix that issue.

joostlek

The PR template isn't there and CI is failing, can you take a look?

The GitHub UI suggestion added quoted period field names without removing the originals or closing their braces, resulting in duplicate keys and invalid JSON. Keep only the quoted versions: 'Period {period} end' and 'Period {period} start', consistent with other field name messages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…dd end time test - Fix _parse_time_str to actually parse seconds when HH:MM:SS format is provided, instead of silently discarding them - Add test for invalid period end time (invalid_time_format_period_end) to complement the existing period start time test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…SS and add end time test" This reverts commit faa14ff.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

johanzander · 2026-03-20T16:05:58Z

This should hopefully fix the PR template issue: #166069

Copilot AI review requested due to automatic review settings March 19, 2026 20:34

home-assistant bot added cla-signed code-quality integration: growatt_server small-pr PRs with less than 30 lines. by-code-owner Quality Scale: silver labels Mar 19, 2026

Copilot started reviewing on behalf of johanzander March 19, 2026 20:35 View session

Copilot AI reviewed Mar 19, 2026

View reviewed changes

johanzander marked this pull request as draft March 19, 2026 20:37

johanzander changed the title ~~growatt_server: fix "services" → "actions" wording in exception message~~ growatt_server: use human-readable labels in exception messages Mar 19, 2026

johanzander marked this pull request as ready for review March 19, 2026 20:51

Copilot AI review requested due to automatic review settings March 19, 2026 20:51

Copilot started reviewing on behalf of johanzander March 19, 2026 20:52 View session

johanzander marked this pull request as draft March 19, 2026 20:53

Copilot AI reviewed Mar 19, 2026

View reviewed changes

NoRi2909 reviewed Mar 19, 2026

View reviewed changes

homeassistant/components/growatt_server/strings.json Outdated Show resolved Hide resolved

johanzander and others added 2 commits March 19, 2026 21:07

johanzander marked this pull request as ready for review March 19, 2026 21:19

Copilot AI review requested due to automatic review settings March 19, 2026 21:19

Merge branch 'dev' into fix/growatt-gold-action-wording

56fe1d7

Copilot started reviewing on behalf of johanzander March 19, 2026 21:19 View session

NoRi2909 reviewed Mar 19, 2026

View reviewed changes

homeassistant/components/growatt_server/strings.json Outdated Show resolved Hide resolved

Copilot AI reviewed Mar 19, 2026

View reviewed changes

homeassistant/components/growatt_server/strings.json Show resolved Hide resolved

NoRi2909 reviewed Mar 19, 2026

View reviewed changes

homeassistant/components/growatt_server/strings.json Outdated Show resolved Hide resolved

johanzander and others added 2 commits March 19, 2026 21:23

Copilot AI review requested due to automatic review settings March 19, 2026 21:27

Copilot started reviewing on behalf of johanzander March 19, 2026 21:27 View session

Copilot AI reviewed Mar 19, 2026

View reviewed changes

homeassistant/components/growatt_server/services.py Outdated Show resolved Hide resolved

joostlek requested changes Mar 19, 2026

View reviewed changes

homeassistant/components/growatt_server/services.py Outdated Show resolved Hide resolved

home-assistant bot marked this pull request as draft March 19, 2026 21:41

johanzander marked this pull request as ready for review March 19, 2026 22:24

Copilot AI review requested due to automatic review settings March 19, 2026 22:24

home-assistant bot requested a review from joostlek March 19, 2026 22:24

Copilot started reviewing on behalf of johanzander March 19, 2026 22:24 View session

Copilot AI reviewed Mar 19, 2026

View reviewed changes

NoRi2909 reviewed Mar 20, 2026

View reviewed changes

homeassistant/components/growatt_server/strings.json Show resolved Hide resolved

Update homeassistant/components/growatt_server/strings.json

66a2543

Co-authored-by: Norbert Rittel <norbert@rittel.de>

Copilot AI review requested due to automatic review settings March 20, 2026 07:30

Copilot started reviewing on behalf of johanzander March 20, 2026 07:30 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

joostlek requested changes Mar 20, 2026

View reviewed changes

home-assistant bot marked this pull request as draft March 20, 2026 15:18

johanzander and others added 2 commits March 20, 2026 15:29

Copilot AI review requested due to automatic review settings March 20, 2026 15:37

Revert "growatt_server: fix _parse_time_str to properly handle HH:MM:…

50a8958

…SS and add end time test" This reverts commit faa14ff.

Copilot started reviewing on behalf of johanzander March 20, 2026 15:37 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

johanzander marked this pull request as ready for review March 20, 2026 15:46

home-assistant bot requested a review from joostlek March 20, 2026 15:47

		return datetime.strptime(f"{parts[0]}:{parts[1]}", "%H:%M").time()
		except (ValueError, IndexError) as err:

-        return datetime.strptime(f"{parts[0]}:{parts[1]}", "%H:%M").time()
-    except (ValueError, IndexError) as err:
+        if len(parts) == 2:
+            # Format HH:MM
+            return datetime.strptime(time_str, "%H:%M").time()
+        # Format HH:MM:SS
+        return datetime.strptime(time_str, "%H:%M:%S").time()
+    except ValueError as err:

Uh oh!

Conversation

johanzander commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

home-assistant bot commented Mar 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

NoRi2909 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

NoRi2909 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

joostlek left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

johanzander commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

johanzander commented Mar 19, 2026 •

edited

Loading