Fix weird summary/by name crash (issue #1255)#1481
Open
Koolvansh07 wants to merge 1 commit intoholoviz:mainfrom
Open
Fix weird summary/by name crash (issue #1255)#1481Koolvansh07 wants to merge 1 commit intoholoviz:mainfrom
Koolvansh07 wants to merge 1 commit intoholoviz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to fix issue #1255.
Problem was when summary key name is same as generated dim name from by(), xarray crashes with confusing MissingDimensionsError.
I added simple check in summary.validate so it fails early with clear ValueError.
Also added regression test in test_xarray.py for the "foo foo" case from issue.
I ran targeted tests and they pass.