Skip to content

Fix schema-qualified TableGroup export names#940

Merged
huydo862003 merged 1 commit into
holistics:masterfrom
cyphercodes:fix-tablegroup-schema-export
Jul 7, 2026
Merged

Fix schema-qualified TableGroup export names#940
huydo862003 merged 1 commit into
holistics:masterfrom
cyphercodes:fix-tablegroup-schema-export

Conversation

@cyphercodes

Copy link
Copy Markdown
Contributor

Summary

  • Stop DBML export from schema-qualifying TableGroup names so exported DBML remains parseable.
  • Add a regression test covering a non-default-schema table group round trip through ModelExporter.

Issue

Fixes #927

Lasting Changes (Technical)

  • DbmlExporter.exportTableGroups now emits TableGroup "name" while still schema-qualifying member table references when needed.

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Lint Checks Passed
  • Unit Tests Passed
  • Coverage Tests Passed
  • Integration Tests Passed
  • Code Review

@huydo862003 huydo862003 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🚀

@huydo862003 huydo862003 added the PR: Bug Fix 🐛 A type of pull request used for changelog categories label Jul 7, 2026
@huydo862003 huydo862003 merged commit 76cd9e3 into holistics:master Jul 7, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 A type of pull request used for changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModelExporter emits schema-qualified TableGroup names that the parser rejects (round-trip failure)

2 participants