Use async tasks instead of blocking sync for store operations#338
Merged
Conversation
The widget message handler was using zarr's `_sync()` to block the Jupyter kernel event loop while waiting on store reads. This freezes the kernel during slow operations like remote store access. Since Jupyter already runs an asyncio event loop and zarr v3 stores expose a native async API, we can schedule store operations as async tasks directly via `asyncio.create_task()` rather than blocking. A `_pending_tasks` set prevents in-flight tasks from being garbage collected, following the same pattern used by lonboard.
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The widget message handler was using zarr's
_sync()to block the Jupyter kernel event loop while waiting on store reads. This freezes the kernel during slow operations like remote store access.Since Jupyter already runs an asyncio event loop and zarr v3 stores expose a native async API, we can schedule store operations as async tasks directly via
asyncio.create_task()rather than blocking. A_pending_tasksset prevents in-flight tasks from being garbage collected, following the same pattern used by lonboard.