HHH-19956: Automated contribution from Perforce //main/clients/Hibernate/7.1/...

[isc-service]

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

https://hibernate.atlassian.net/browse/HHH-19956

[StefanWittmannISD]

This PR is a follow up from #11520 (see my comment there for additional context).

[beikov]

I tried to look through most of the dialect, but I surely missed something. Overall, I would please like to ask you to respect our code style (e.g. always use blocks for if, whitespace, etc.) everywhere and look through the function, column type and other registrations once more.

Do you test this dialect against the Hibernate ORM testsuite? I'm happy to accept adding a profile to local.databases.gradle and if you have a docker image, also an entry to docker_db.sh so that this can actually also be tested by others.

[StefanWittmannISD]

Thank you for your thorough review and suggestions. We are looking at these and will provide reasoning and/or follow up with the appropriate changes.

[StefanWittmannISD]

We will update the PR shortly.

We reviewed all affected code files and updated them to fully align with the project’s coding style, including if block formatting and whitespace. All changes were made based on your previous code suggestions.

Specifically, we added:
case LONG32VARBINARY: return "longvarbinary";
while also keeping:
case LONGVARBINARY: return "longvarbinary";

We kept it since LONGVARBINARY is still referenced by simpleSqlType(...) during registerColumnTypes(). The same approach is applied to LONGVARCHAR.

We did test this dialect against the Hibernate ORM testsuite.

[beikov]

Superseded by #11740