Open
Conversation
luis11011
requested changes
Sep 20, 2021
Member
luis11011
left a comment
luis11011
left a comment
There was a problem hiding this comment.
Have in mind the format of the code in the creator file. Apart from that this is nicely done. Please pull the latest updates from develop to properly create this tests file.
| t.create(method="rows.append", variant="single_some_cols", dfs=[df2], names_map={"First":["function","price"],"Second":["weight(t)","id"],"Third":["Cybertronian","birth"]}) | ||
| t.create(method="rows.append", variant="single_one_col", dfs=[df2], names_map={"Only":["japanese name","billingId"]}) | ||
| t.create(method="rows.append", variant="multiple_complete", dfs=[df2,df3]) | ||
| t.create(method="rows.append", variant="multiple_some_cols", dfs=[df2,df3], names_map={"First":["last position seen","product","ip_test"],"Second":["date arrival","firstName","object_test"],"Third":["names","lastName","email_test"]}) |
Member
There was a problem hiding this comment.
Here you're referencing 'object_test' but not creating that column on the dataframe, this repeats in other tests.
luis11011
force-pushed
the
develop-21.9
branch
from
81b722a to
e5c8448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.