Add required artifacts to image instead of deployment #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added a `prefix()` setter thet appends a `.` to handle files with overlapping prefixes. Ex: - `test_file.1234567890.gz` - `test_file_v2.134567890.gz` However, this introduced a bug where `FileInfoPoller` would not find the correct latest timestamp when starting, so we would reprocess files all the way back to the `start_after` date. `FileInfoPoller` used the plain `prefix` when querying the `files_processed` table. While the state recorder used `FileInfo.prefix` which would never have the appended `.`. I added a getter `prefix_without_dot()` getter to mirror the setters of the config builder, so when you go to use the prefix your autocomplete will let you know there’s a dotless version available, and you can make the decision of which to use.
bbalser
force-pushed
the
bbalser/global-bundle
branch
from
61bcd87 to
0c9affa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.