fix to_xml for unprocessable_entity responses#250
Open
kzink wants to merge 1 commit intoheartcombo:mainfrom
Open
fix to_xml for unprocessable_entity responses#250kzink wants to merge 1 commit intoheartcombo:mainfrom
kzink wants to merge 1 commit intoheartcombo:mainfrom
Conversation
Member
|
@kzink apologies for the gap here... are you still running into issues with to_xml that might need responders fixing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 7+ has removed
ActiveModel::Errors#to_xmlwhich responders was relying on to emit:unprocessable_entityerrors in xml format. You'll see something like this if it tries to render the error collection into a response:I cobbled together a fix for this by pulling out the formatting method used in Rails 6 to restore the functionality. Unsure if this works in Rails <6 so it might be worth gating with a conditional.