Skip to content

Remove dependency on cryptonite and hashing#1115

Open
tm-drtina wants to merge 2 commits intohaskell-nix:masterfrom
tm-drtina:tomas/remove-cryptonite-hashing
Open

Remove dependency on cryptonite and hashing#1115
tm-drtina wants to merge 2 commits intohaskell-nix:masterfrom
tm-drtina:tomas/remove-cryptonite-hashing

Conversation

@tm-drtina
Copy link

With the recent dependency updates the switch from cryptonite and hashing is straightforward.

supersedes: #1104

Copy link
Collaborator

@soulomoon soulomoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ConnorBaker added a commit to ConnorBaker/hnix that referenced this pull request Jan 12, 2026
Consolidate on crypton for all cryptographic hashing needs. This removes
the dependency on both `cryptonite` and `hashing` packages.

Changes:
- Remove cryptonite and hashing from hnix.cabal build-depends
- Update Builtins.hs to use Crypto.Hash from crypton
- Consolidate hash imports in Effects/Derivation.hs
- Remove PackageImports pragma since no longer needed

Based on: haskell-nix#1115

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@yaitskov
Copy link

Wow

#1117

@yaitskov
Copy link

yaitskov commented Feb 11, 2026

With the recent dependency updates the switch from cryptonite and hashing is straightforward.
@tm-drtina,

How do you use hnix?
It turned out that besides this PR cryptonite is still used in hnix-store.
So I have to do another PR.
I haven't found unmerged PR in hnix-store.

haskell-nix/hnix-store#305

@tm-drtina
Copy link
Author

Looking at the hnix-store PR, it (hnix-store-nar) has cryptonite only in test dependencies, not in the library

@yaitskov
Copy link

dependencies

well, transitive dependency in tests is also counts.

I discovered that hnix-store broke API. FileReclusive data constructor is renamed to NixArchive or removed?

@yaitskov
Copy link

Wow

#1117

I pushed force the PR with @tm-drtina and added fix to hnix-store api that is required after applying haskell-nix/hnix-store#305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants