feat(secret): support multiple ownerRefs#1044
Open
sebglon wants to merge 5 commits intohashicorp:mainfrom
Open
feat(secret): support multiple ownerRefs#1044sebglon wants to merge 5 commits intohashicorp:mainfrom
sebglon wants to merge 5 commits intohashicorp:mainfrom
Conversation
Contributor
Author
|
Hello, @benashz, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #882
Support multiple OwnerReferences.
K8S doc here
For compatibilty with existing deployment, i can't add the ownerRefences.contoller on the check (with a deep-equal).
But if we have a way to upgrade all existing secrets managed by VSO, we can use the deepEqual.