hclwrite: add read and write API for ObjectConsExpr - #811
Open
bbasata wants to merge 7 commits into
Open
Conversation
bbasata
force-pushed
the
bbasata/rewrite-objects
branch
from
June 19, 2026 21:13
460ef76 to
88a6bc4
Compare
bbasata
force-pushed
the
bbasata/rewrite-objects
branch
from
August 4, 2026 22:34
5999eae to
321afff
Compare
Collaborator
Author
Collaborator
Author
@mildwonkey: I'm marking this one for review, with no expectation that it's quite ready to merge yet. It's simply the next one in the sequence that we're collaborating on. I've exercised this in a client application to a high degree of confidence. Now, to turn "the change that works" into "the right change." |
bbasata
marked this pull request as ready for review
August 4, 2026 22:38
bbasata
commented
Aug 4, 2026
Collaborator
Author
ℹ️ This new test will see some changes in its tree. This is a consequence of parsing the object-construct item key as an expression, so it now has a richer sub-tree. |
bbasata
commented
Aug 4, 2026
bbasata
force-pushed
the
bbasata/rewrite-objects
branch
from
August 4, 2026 23:46
e3972e2 to
0d7feb5
Compare
bbasata
changed the base branch from
main
to
bbasata/parse-object-construct-expressions
August 4, 2026 23:47
ObjectConsExpr.SetItemRaw() and ObjectConsExpr.ItemFor()
bbasata
force-pushed
the
bbasata/rewrite-objects
branch
from
August 5, 2026 05:08
0d7feb5 to
88dae3b
Compare
ObjectConsExpr.SetItemRaw() and ObjectConsExpr.ItemFor()ObjectConsExpr
bbasata
force-pushed
the
bbasata/rewrite-objects
branch
from
August 5, 2026 05:40
2356309 to
02f89ac
Compare
bbasata
force-pushed
the
bbasata/rewrite-objects
branch
from
August 5, 2026 13:48
f7242e8 to
923c509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rewrite object values.
Related Issue
#810