Fix missing timestamps in file logging output - #2092
Conversation
Problem: When using file logging (log_file configuration), log messages written to files lack timestamps, while console output includes them. This inconsistency makes it difficult to correlate events and analyze logs when file logging is used. The issue occurs because the MultiWriter sends logs to both console (with timestamp wrapper) and file (without timestamp wrapper) outputs. Solution: Wrap the file writer with the same logWriter that adds timestamps to console output. This ensures both console and file logs have identical timestamp formatting while preserving all existing functionality including log rotation. Changes: - Modified logging/logging.go to wrap logFile with logWriter before adding to MultiWriter - Preserves log rotation, filtering, and all other existing features - No configuration changes required - Maintains same performance characteristics Fixes timestamp inconsistency between console and file logging output.
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Liran Amrani seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
@pajay-rao @nitin-sachdev-29 @sreeram77 @sanikachavan5 please someone can review? |
|
@hc-github-team-consul-core somebody can review??? |
|
@tvoran can you review please? |
|
that PR Fixes #1714 |
|
Sorry for the direct ping! I wanted to surface this quick fix for missing timestamps in the file logging output (#2092). Currently, writing logs to a file bypasses the standard timestamp formatting that stdout uses. This makes production logs really difficult to parse and align during incident response. This PR ensures file logs match stdout's logging format. All automated CI tests are fully green and I have added test coverage for the timestamp logic. Whenever you have a slot open during your next triage or maintenance cycle, I would appreciate a quick review. Thank you for your time! |
Problem: ( Fixes #1714 issue)
When using file logging (log_file configuration), log messages written to files lack timestamps, while console output includes them. This inconsistency makes it difficult to correlate events and analyze logs when file logging is used.
The issue occurs because the MultiWriter sends logs to both console (with timestamp wrapper) and file (without timestamp wrapper) outputs.
Solution:
Wrap the file writer with the same logWriter that adds timestamps to console output. This ensures both console and file logs have identical timestamp formatting while preserving all existing functionality including log rotation.
Changes:
Fixes timestamp inconsistency between console and file logging output.


before solution -
after bug fix -