Conversation
|
I don't really have a background in TS/GJS and would appreciate someone's help on this for review and further refactoring. |
I was refactoring this as well, 👍 , had just started. You are way ahead. All yours. |
| import * as VKeyboard from './src/utils/keyboard'; | ||
|
|
||
| const ExtensionUtils = imports.misc.extensionUtils; | ||
| const extensionObject = Extension.lookupByUUID('gestureImprovements@gestures'); |
| private _addReloadDelayFor: AllSettingsKeys[]; | ||
|
|
||
| constructor() { | ||
| super(extensionObject.metadata); |
There was a problem hiding this comment.
constructor(metadata: ExtensionMetadata) {
super(metadata)
extension/extension.ts
Outdated
| const extensionObject = Extension.lookupByUUID('gestureImprovements@gestures'); | ||
|
|
||
| class Extension { | ||
| class GNOMEGestureImprovementsExtension extends Extension { |
There was a problem hiding this comment.
export default class GnomeGestureImprovements extends Extension {
line 156 is not necessary??
| @@ -1,5 +1,5 @@ | |||
| import GLib from '@gi-types/glib2'; | |||
| import { imports } from 'gnome-shell'; | |||
| import { Extension } from 'resource:///org/gnome/shell/extensions/extension'; | |||
There was a problem hiding this comment.
( Extension, ExtensionMetadata} from ....
|
Maybe I can learn from this PR for pano (clipboard manager) |
|
Is there any news on this? This extension is currently keeping me on Fedora 38, which goes EOL in about 3 months' time. If there's anything I can do to get the extension updated, please let me know! |
|
It would be great if this branch can be merged in, |
Resolves #206
Revamp as per https://gjs.guide/extensions/upgrading/gnome-shell-45.html#port-extensions-to-gnome-shell-45 and https://github.com/swsnr/gnome-shell-extension-typescript-template/tree/e8116afac1ad690d300985183238b51044445a3d
Change
scripts/transpile.tsto accommodate the above point