Skip to content

Conversation

@tfo-dot
Copy link
Contributor

@tfo-dot tfo-dot commented Jan 8, 2026

About

It updates workflow to deno 2.x. The types and everything are updated to pass the deno run check command. Also removed node stuff since we shouldn't deploy directly to npm while we're using JSR (which supports npm and other environments)

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

In an effort to remove the broken dependencies the GuildTextChannel type lost the all the thread realted methods except startThread which was needed for message structure which relies on the method. Going forward the channel should be casted to GuildThreadAvaliableChannel if wanting to use the thread realted methods.

Although the code was tested, I ran some of the files in the test folder, and it runned correctly but we do not have the ability to harmony against the discord api correctly without rewriting tests to actual test instead of hand picked collection of samples/functions

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have a comment in file, just answer that and should be good to go

tho, i wonder if jsr will happily accept class object manipulation but we'll see

@tfo-dot
Copy link
Contributor Author

tfo-dot commented Jan 8, 2026

tho, i wonder if jsr will happily accept class object manipulation but we'll see

If that breaks too, I'll have to restructure half of the code so I hope it doesn't reject

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should take a few moment til jsr release since i dont have much time to do it recently 😭

@Helloyunho Helloyunho merged commit 5e0631c into harmonyland:main Jan 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants