Use substitute_object for carousel_config type fidelity#620
Merged
Conversation
substitute_variables always returns strings, breaking booleans and other types. substitute_object preserves native JSON types for single-variable references (int, bool, dict, list).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix from Codex review on #619: the carousel_config resolver used
substitute_variableswhich always returns strings. Templated values like booleans would become"True"instead oftrue.Switch to
substitute_objectwhich preserves native JSON types for single{{var}}references.Test plan
default_index: "{{temp.reading_start_index}}"still resolves to integer