-
Notifications
You must be signed in to change notification settings - Fork 1
Add literals support #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
halotukozak
wants to merge
13
commits into
master
Choose a base branch
from
literals
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add literals support #169
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
dbd4d51
Add literals support
halotukozak 7f70fc0
refactor: update `DebugSettings` to a parameterized type and streamli…
halotukozak 334deeb
refactor: adjust token handling and refine context ownership for impr…
halotukozak f2cc79e
refactor: simplify tree transformations, debug utils, and token compi…
halotukozak 7a16428
refactor: remove `DebugPosition` opaque type and simplify debug utili…
halotukozak 1ba632c
Merge branch 'master' into literals
halotukozak 9d659ec
Merge branch 'master' into literals
halotukozak 4ffa1fc
Merge remote-tracking branch 'origin/literals' into literals
halotukozak f044886
Refactor `byLiteral` to support method-based access with improved typ…
halotukozak 99e8fcf
Refactor lexer internals to replace `.unsafeMap` with `.map`, remove …
halotukozak 67b1a88
Refactor `CompileNameAndPattern` to simplify token extraction logic u…
halotukozak fe6cb91
Merge branch 'ignored-tokens-vals' into token-definition
halotukozak 830a7f6
Merge branch 'token-definition' into literals
halotukozak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
changeOwner(sym)call is added to the result ofrhsFn.unsafeApply. While this may be necessary for correct symbol ownership in the macro-generated code, ensure this doesn't break existing functionality where the owner was previously not changed. If this fixes a bug, consider documenting why this change is needed.